** CID 1670535: Incorrect expression (IDENTICAL_BRANCHES)
/gumps/Dynamic_slider.cc: 509 in Dynamic_slider::mouse_drag(int, int)()


_____________________________________________________________________________________________
*** CID 1670535: Incorrect expression (IDENTICAL_BRANCHES)
/gumps/Dynamic_slider.cc: 509 in Dynamic_slider::mouse_drag(int, int)()
503 }
504
505 int newval = val_from_thumb();
506 if (newval != val) {
507 val = newval;
508 gwin->add_dirty(get_rect());
>>> CID 1670535: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "this->call_usecode_callback()" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
509 if (call_usecode_callback()) {
510 return true; // `this` may be destroyed.
511 }
512 return true;
513 }
514

** CID 1670534: Memory - corruptions (REVERSE_NEGATIVE)
/mapedit/combo.cc: 1601 in Combo_chooser::search(const char *, int)()


_____________________________________________________________________________________________
*** CID 1670534: Memory - corruptions (REVERSE_NEGATIVE)
/mapedit/combo.cc: 1601 in Combo_chooser::search(const char *, int)()
1595 scroll_row_vertical(row0 - 1);
1596 }
1597 while (row0 < rows.size() - 1 && i >= static_cast<int>(rows[row0 + 1].index0)) { // Below?
1598 scroll_row_vertical(row0 + 1);
1599 }
1600 const int newsel = i; // New selection.
>>> CID 1670534: Memory - corruptions (REVERSE_NEGATIVE)
>>> You might be using variable "newsel" before verifying that it is >= 0.
1601 if (newsel >= 0 && newsel < static_cast<int>(info.size())) {
1602 select(newsel);
1603 }
1604 render();